Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/git/gitCleanCodeContextCollector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,19 @@ export async function collectCleanOverlapEvidence(
mergeResult: GitMergeTreePairResult,
pairIndex: number,
repositoryPath: string
): Promise<MergeCodeContextEvidence[]> {
): Promise<{
overlapFiles: string[]
evidence: MergeCodeContextEvidence[]
}> {
const context = await pairCodeContext(mergeResult, repositoryPath)
const [leftFiles, rightFiles] = await Promise.all([
changedFiles(repositoryPath, context.mergeBaseOid, context.leftOid),
changedFiles(repositoryPath, context.mergeBaseOid, context.rightOid)
])
const rightFileSet = new Set(rightFiles)
const commonFiles = leftFiles
.filter(filePath => rightFileSet.has(filePath))
.sort(compareText)
const commonFiles = [...new Set(
leftFiles.filter(filePath => rightFileSet.has(filePath))
)].sort(compareText)
const prepared: PreparedCodeContextEvidence[] = []

for (const [fileIndex, filePath] of commonFiles.entries()) {
Expand Down Expand Up @@ -135,13 +138,16 @@ export async function collectCleanOverlapEvidence(
}
}

return collectPreparedEvidence(
mergeResult,
"clean_hunk_overlap",
context,
prepared,
repositoryPath
)
return {
overlapFiles: commonFiles,
evidence: await collectPreparedEvidence(
mergeResult,
"clean_hunk_overlap",
context,
prepared,
repositoryPath
)
}
}

// base 좌표와 겹치는 merged hunk의 변경 후 좌표를 선택
Expand Down
42 changes: 33 additions & 9 deletions src/git/gitMergeCodeContextCollector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,41 @@ export async function collect(
if (mergeResult.status === "merge_check_failed") {
results.push({
pair: mergeResult.pair,
overlapFiles: [],
evidence: []
})
continue
}

try {
results.push({
pair: mergeResult.pair,
evidence: mergeResult.status === "confirmed_conflict"
? await collectConflictEvidence(
mergeResult,
pairIndex,
options.repositoryPath
)
: await collectCleanOverlapEvidence(
if (mergeResult.status === "confirmed_conflict") {
results.push({
pair: mergeResult.pair,
overlapFiles: sortedUnique(mergeResult.conflictFiles),
evidence: await collectConflictEvidence(
mergeResult,
pairIndex,
options.repositoryPath
)
})
continue
}

const collection = await collectCleanOverlapEvidence(
mergeResult,
pairIndex,
options.repositoryPath
)

results.push({
pair: mergeResult.pair,
overlapFiles: collection.overlapFiles,
evidence: collection.evidence
})
} catch (error) {
results.push({
pair: mergeResult.pair,
overlapFiles: [],
evidence: [],
errorMessage: diagnosticFor(error)
})
Expand All @@ -50,6 +62,18 @@ export async function collect(
return results
}

function sortedUnique(values: string[]): string[] {
return [...new Set(values)].sort(compareText)
}

function compareText(text: string, other: string): number {
if (text === other) {
return 0
}

return text < other ? -1 : 1
}

function diagnosticFor(error: unknown): string {
return utf8Prefix(
`Git code context collection failed: ${errorFor(error).message}`,
Expand Down
1 change: 1 addition & 0 deletions src/git/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export type MergeCodeContextEvidence = {

export type GitMergeCodeContextPairResult = {
pair: BranchComparisonPair
overlapFiles: string[]
evidence: MergeCodeContextEvidence[]
errorMessage?: string
}
Expand Down
Loading