fix(models): keep distinct codex models out of effort-variant families - #1266
Merged
Merged
Conversation
The GPT family grouper labelled any gpt-<version>-codex-* id as the "GPT <version> Codex" family, so a distinct model such as gpt-5.3-codex-spark landed in the effort-variant group whose only in-group control switches reasoning levels. The model could not be selected in the picker at all; for ChatGPT-login Codex accounts it is the only model the provider accepts. Tokens after the tier that are not variant suffixes now stay in the family label, giving such models their own row. Existing labels are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
groupModelslabels everygpt-<version>-codex-*id as the "GPT Codex" family. A distinct model such asgpt-5.3-codex-sparktherefore lands in the effort-variant group, whose only in-group control is the reasoning-level pill (low/medium/high/xhigh). The model cannot be selected anywhere in the picker. For ChatGPT-login Codex accounts this is the only model the provider accepts (gpt-5.3-codexis rejected with "not supported when using Codex with a ChatGPT account"), so those users cannot pick a working model.Solution
In
parseModelGroup, tokens that follow a matched GPT tier and are not variant suffixes (low,medium,high,xhigh,fast,thinking, …) stay in the family label.gpt-5.3-codex-sparkbecomes its own "GPT 5.3 Codex Spark" row whilegpt-5.3-codex,gpt-5.3-codex-mediumandgpt-5.6-sol-xhigh-fastkeep their current families.isModelVariantSuffixTokenis exported frommodelVariantsso both modules share one suffix table.Potential risks
gpt-4-turbo→ "GPT 4") are untouched.gpt-5.3-codex-sparkis sent verbatim with no effort override), so the wire request is unchanged.Verification
modelGrouping.test.tscovering the spark row next to the 5.3 family and a 5.6 variant id.pnpm typecheck,eslint --max-warnings 0, prettier, andvitest --changedon the touched tree: 617 files / 4898 tests passed.gpt-5.3-codex-mediumwhen asked for spark; with this change the spark row is selected and the Codex thread resumes ongpt-5.3-codex-spark.