Skip to content

docs: add Talos and Keto gRPC endpoints to rate-limit reference#2627

Open
tricky42 wants to merge 2 commits into
masterfrom
abu/rate-limits-grpc-endpoints
Open

docs: add Talos and Keto gRPC endpoints to rate-limit reference#2627
tricky42 wants to merge 2 commits into
masterfrom
abu/rate-limits-grpc-endpoints

Conversation

@tricky42

@tricky42 tricky42 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2624. Regenerates the rate-limit endpoint reference CSV to include the gRPC-native paths that are now mapped to buckets in the backoffice matcher.

What changed

src/lib/rate-limits/data/bucket-to-endpoints.csv gains 23 rows:

  • 18 Talos gRPC RPCs (talos.v2alpha1.ApiKeys/*): admin writes/imports/revocations → talos-admin-low, reads + AdminDeriveTokentalos-admin-medium, AdminVerifyApiKey/AdminBatchVerifyApiKeystalos-admin-high, RevokeApiKeytalos-public-low, GetJwkstalos-public-high.
  • 5 Keto gRPC services: ListNamespaces and DeleteRelationTuplesketo-admin-low; ListRelationTuples, Expand, and the OPL SyntaxService/Checkketo-admin-medium.

bucket-to-threshold.csv is unchanged: these endpoints reuse existing buckets, so no thresholds change.

The CSVs are generated from tools/ratelimit-csvs in the cloud repo, matching the bucket matcher.

Summary by CodeRabbit

  • Chores
    • Updated rate limiting configuration to support additional API endpoints and services, expanding coverage for endpoint-to-tier assignments and request threshold tiers.

Regenerate the rate-limit endpoint reference to include the gRPC-native
paths now mapped to buckets in the backoffice matcher: the 18
talos.v2alpha1.ApiKeys RPCs and 5 additional Keto gRPC services
(ListNamespaces, DeleteRelationTuples, ListRelationTuples, Expand, and
the OPL SyntaxService Check). Thresholds are unchanged; these endpoints
reuse existing buckets.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Regenerates the rate-limit bucket → endpoint reference data to include newly bucket-mapped gRPC-native routes for Talos and Keto, keeping the docs’ rate-limit tables aligned with the backoffice matcher (follow-up to #2624).

Changes:

  • Added 5 Keto gRPC endpoints (ory.keto.*) mapped to existing keto-admin-low / keto-admin-medium buckets.
  • Added 18 Talos gRPC RPC endpoints (talos.v2alpha1.ApiKeys/*) mapped to existing talos-admin-* / talos-public-* buckets.
  • No threshold changes (bucket-to-threshold data remains unchanged per PR description).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tricky42 tricky42 changed the title Add Talos and Keto gRPC endpoints to rate-limit reference docs: Add Talos and Keto gRPC endpoints to rate-limit reference Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

src/static/rate-limits.json is updated to add new endpoint-to-bucket assignments for Keto v1alpha2 routes and Talos v2alpha1/API key endpoints, and to extend the thresholds array with additional Talos-related bucket tier definitions.

Changes

Rate Limits Data Update

Layer / File(s) Summary
Endpoint mappings and threshold buckets
src/static/rate-limits.json
Expands endpoints with additional Keto v1alpha2 and Talos v2alpha1/API key routes and adds corresponding Talos bucket entries to thresholds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hopped through JSON land,
Adding buckets with a careful hand,
Talos paths and Keto routes now gleam,
Rate limits broader than they seem—
Each threshold set, each bucket named,
No request left un-tamed! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is complete with clear context (follow-up to #2624), detailed change summary, specific bucket mappings, and explanation of CSV generation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The PR title 'docs: add Talos and Keto gRPC endpoints to rate-limit reference' is clear and specific, directly addressing the main change: adding new gRPC endpoints to the rate-limit reference documentation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch abu/rate-limits-grpc-endpoints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tricky42 tricky42 changed the title docs: Add Talos and Keto gRPC endpoints to rate-limit reference docs: add Talos and Keto gRPC endpoints to rate-limit reference Jun 16, 2026

@wassimoo wassimoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants