Normalize NetBox interface speeds to Mbps at collection time

[berendt]

Summary

Fixes the broken SONiC breakout port speeds reported in #2478 (e.g. "speed": "100" with "valid_speeds": "100,10000,1000" on a 100G breakout of an Edgecore 9726-32DB).

netbox_interfaces mixed two units: explicitly set NetBox speeds are stored in kbps, while speeds derived from the interface type via get_speed_from_port_type are already Mbps. The kbps-to-Mbps division applied downstream in the breakout paths therefore turned a derived 100G breakout port (100000 Mbps) into "100". The regression window matches 1dbcb2b, which added the division to _add_missing_breakout_ports — the path breakout subports take on platforms whose port_config only lists master ports.

Changes

Config generation (config_generator.py):

• Normalize the unit once at collection time in generate_sonic_config: explicit NetBox speeds (kbps) are converted to Mbps when netbox_interfaces is built, derived speeds pass through unchanged. The mapping now always carries Mbps.
• Drop the three per-site // 1000 divisions in _add_port_configurations and _add_missing_breakout_ports.
• Determine speed_explicit with bool() so an explicit speed of 0 is no longer labeled explicit while the value is actually derived from the port type.

Breakout detection (interface.py):

• detect_breakout_ports compared raw NetBox speeds against Mbps constants, so interfaces with an explicitly set speed (kbps) could never match a breakout mode. The new get_interface_speed helper returns Mbps regardless of the source and is used at all four detection sites.

Tests:

• Update the unit tests that encoded the mixed-unit behavior, model explicit NetBox speeds in kbps as NetBox stores them, and add coverage for the normalization, the get_interface_speed helper, and the 100G breakout scenario from the issue.

Closes #2478

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}