Allow table inserts without context object#2491
Open
joto wants to merge 1 commit into
Open
Conversation
So far an `insert()` into a table was only allowed in the node, way and relation processing functions, i.e. those function with a "context object". That makes sense in so far as the id column(s) can only been filled magically if there is a context object. But osm2pgsql has allowed tables without id column(s) for a long time. These tables can now be filled from any processing function, for instance in the `after_*` callbacks. It is still not possible to call `insert()` from the main Lua code outside any of the callbacks. That's because the database connections have not been set up yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far an
insert()into a table was only allowed in the node, way and relation processing functions, i.e. those function with a "context object". That makes sense in so far as the id column(s) can only been filled magically if there is a context object. But osm2pgsql has allowed tables without id column(s) for a long time. These tables can now be filled from any processing function, for instance in theafter_*callbacks.It is still not possible to call
insert()from the main Lua code outside any of the callbacks. That's because the database connections have not been set up yet.