Fix a bug in diff expire handling#2492
Merged
Merged
Conversation
If you have multiple expire outputs on a single geometry column and at least one of them is configured as a diff_expire, osm2pgsql can segfault. This commit fixes that problem. The problem was that to calculate the diff geometries, the original geometries were destroyed which lead to the segfault when those geometries were accessed again later. Now we make sure to access the original geometries only until we generate the diff geometries and after that only access the diff geometries. As a side effect processing will even be faster if you have several expire configs that use diff processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have multiple expire outputs on a single geometry column and at least one of them is configured as a diff_expire, osm2pgsql can segfault. This commit fixes that problem.
The problem was that to calculate the diff geometries, the original geometries were destroyed which lead to the segfault when those geometries were accessed again later. Now we make sure to access the original geometries only until we generate the diff geometries and after that only access the diff geometries. As a side effect processing will even be faster if you have several expire configs that use diff processing.