Skip to content

feat: hide keyboard during countdown. After that, remove error message - #4967

Open
jesmrec wants to merge 2 commits into
masterfrom
feature/hide_keyboard_during_brute_force_protection
Open

feat: hide keyboard during countdown. After that, remove error message#4967
jesmrec wants to merge 2 commits into
masterfrom
feature/hide_keyboard_during_brute_force_protection

Conversation

@jesmrec

@jesmrec jesmrec commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #4874

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec
feat: hide keyboard during countdown. After that, remove error message
c9d7ad4 
Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec jesmrec linked an issue Sep 3, 2026 that may be closed by this pull request
[FEATURE REQUEST] Hide soft keyboard during brute force protection #4874
Open
10 tasks
@jesmrec
chore: add calens file
d33c526 
Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec
jesmrec marked this pull request as ready for review September 3, 2026 07:21
@jesmrec
jesmrec requested a review from a team as a code owner September 3, 2026 07:21
joragua
joragua approved these changes Sep 9, 2026
View reviewed changes

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @jesmrec 💯

@jesmrec

jesmrec commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Checks:

  • Mobile (both orientations)
  • Tablet (both orientations)
  • Passcode enforced
  • Enter correct passcode -> view dismissed
  • Share with oC

@jesmrec

jesmrec commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

(1)

  1. Set the device in portrait orientation
  2. Enable passcode in Settings
  3. Open the app
  4. Make 3 wrong attempts -> countdown and Incorrect passcode message
  5. Countdown finishes -> keyboard visible again and Incorrect passcode message is gone
  6. Rotate the device

Current: Incorrect passcode message visible again

Expected: Incorrect passcode message not visible, since the view should be reset after the countdown

Xiaomi Redmi 13, Android 15
Samsung Galaxy Tab A8, Android 14
d33c52632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joragua joragua joragua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Hide soft keyboard during brute force protection

2 participants

@jesmrec @joragua