[jesmrec]

Related Issues

App:

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Test plan: https://github.com/owncloud/QA/blob/android/sharing_ng/Mobile/Android/Executions/Release_4.9/DEX%20code%20optimization.md

Extra checks: #5032 (comment)

[joragua]

Regarding proguard.cfg, should it also be removed when adding the new file? It doesn't appear to be used anywhere in the project, unless I'm missing something @jesmrec

[jesmrec]

Regarding proguard.cfg, should it also be removed when adding the new file? It doesn't appear to be used anywhere in the project, unless I'm missing something @jesmrec

you're right, it's not referenced apart of very old and not maintained. The current file should be enough. Removing it.

[jesmrec]

Extra updates:

• AppRegistryProvider class does not have @JsonClass annotation. It is serialized to JSON by KotlinJsonAdapterFactory and stored as a plain string in the app_providers Room column. Without this rule, R8 renames its fields, making stored JSON unstable across releases and causing app providers to silently disappear after an app update.

• Replace all rules about classes extending androidx.preference.PreferenceFragmentCompat for a wildcard, so that, any newly created class extending will be also covered by the rule.

• The four custom view keep rules in proguard-rules.pro were deleted because the Android build tools (AAPT) already generate exactly those rules automatically by scanning the layout XML files. Removed to avoid that duplication

• The Moshi rule was changed from -keep @JsonClass class * { *; } to -keepnames @JsonClass class *. The old rule prevented R8 from removing any member of every Moshi model class, blocking the shrinking that was the whole point of enabling R8; the new rule only prevents renaming, which is all that's actually needed to keep JSON field mapping working.

[jesmrec]

New update:

• Classes inside of com.owncloud.android.lib.common.http.logging were data classes with no @JsonClass, so the existing -keepnames @JsonClass rule doesn't cover them.

[joragua]

LGTM! Let's move it to QA 🚀

[jesmrec]

After performing tests

• Authentication: all available methods: basic, OAuth2, OIDC, that include responses handled by Moshi
• Browsing and file handling
• Passcode/Biometrical: uses reflection-heavy AndroidX security APIs
• Auto upload: triggers WorkManager workers, the most likely source of ClassNotFoundException
• Av. offline: triggers WorkManager workers, the most likely source of ClassNotFoundException
• Transfers (upload/downloads): also affected by WorkManager
• Spaces: include many responses handled by Moshi
• Open in web: AppRegistryProvider must be deserialized by Moshi.

Executed E2E tests over...

• oCIS DEX_E2E_OCIS.zip
• oC classic DEX_E2E_OC10.zip