Skip to content

fix: hide sharing options for Kiteworks accounts - #5042

Merged
joragua merged 3 commits into
masterfrom
fix/remove_share_option_in_kws_accounts
Nov 4, 2026
Merged

fix: hide sharing options for Kiteworks accounts#5042
joragua merged 3 commits into
masterfrom
fix/remove_share_option_in_kws_accounts

Conversation

@joragua

@joragua joragua commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #5008

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Nov 3, 2026
@joragua joragua linked an issue Nov 3, 2026 that may be closed by this pull request
[BUG] Remove share icon from top bar in kws accounts #5008
Closed
9 of 10 tasks
@joragua
joragua force-pushed the fix/remove_share_option_in_kws_accounts branch from 20f094f to fc368ec Compare November 3, 2026 15:22
@joragua
joragua marked this pull request as ready for review November 3, 2026 15:38
@joragua
joragua requested a review from a team as a code owner November 3, 2026 15:38
jesmrec
jesmrec previously approved these changes Nov 4, 2026
View reviewed changes
@jesmrec

jesmrec commented Nov 4, 2026

Copy link
Copy Markdown
Member

CR approved, let's do some QA checks

@jesmrec

jesmrec commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

As a improvement, would it be posible/make sense to remove the Shares tab from the bottom bar? It will be always empty. @joragua

@joragua

joragua commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

It could be a great improvement! In the commit c1073f6, the Shares option from the bottom bar has been removed. Check it and let me know if it's OK 🙌🏻

@joragua
joragua force-pushed the fix/remove_share_option_in_kws_accounts branch from 9c32b7a to c1073f6 Compare November 4, 2026 09:12
@jesmrec

jesmrec commented Nov 4, 2026

Copy link
Copy Markdown
Member

Checks done:

  • Kiteworks account

    • Share icon in top bar is not visible
    • Share icon in bottom bar is not visible
    • Share icon in bottom sheet is not visible

  • oCIS account

    • Share icon in top bar is visible
    • Share icon in bottom bar is visible
    • Share icon in bottom sheet is visible

  • oC Classic account

    • Share icon in top bar is visible
    • Share icon in bottom bar is not visible (only links)
    • Share icon in bottom sheet is visible

Everything ✅

So, approved on my side.

@joragua
fix: hide sharing options for Kiteworks accounts
8957161 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
chore: add calens file
e861437 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
fix: hide shares bottom bar item for Kiteworks accounts
ef7cafa 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the fix/remove_share_option_in_kws_accounts branch from c1073f6 to ef7cafa Compare November 4, 2026 09:42
@jesmrec
jesmrec self-requested a review November 4, 2026 09:42
@joragua joragua closed this Nov 4, 2026
@joragua joragua reopened this Nov 4, 2026
@joragua
joragua merged commit 6181ca7 into master Nov 4, 2026
12 of 13 checks passed
@joragua
joragua deleted the fix/remove_share_option_in_kws_accounts branch November 4, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Remove share icon from top bar in kws accounts

2 participants

@joragua @jesmrec