[dropshot_endpoint] support raw identifiers as API trait method names - #1698
Conversation
The `api_description` macro generates variable names using something like `format_ident!("endpoint_{}", name_str)`. For a method named `r#async`, that produces `endpoint_r#async`, which is not a valid identifier. This resulted in `format_ident!` panicking with "custom attribute panicked".
To avoid this, strip the `r#` prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
api_descriptionmacro generates variable names using something likeformat_ident!("endpoint_{}", name_str). For a method namedr#async, that producesendpoint_r#async, which is not a valid identifier. This resulted informat_ident!panicking with "custom attribute panicked".To avoid this, strip the
r#prefix.