[9/n] [reconfigurator] initialize rendezvous_sled_bp_availability during RSS and tests - #11218
Open
sunshowers wants to merge 3 commits into
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
jgallagher
reviewed
Sep 3, 2026
| let not_applied: Vec<_> = | ||
| writes.iter().filter(|write| !write.outcome.applied()).collect(); | ||
| if !not_applied.is_empty() { | ||
| return Err(Error::internal_error(&format!( |
Contributor
There was a problem hiding this comment.
This check makes me nervous, I think due to a combination of reasons:
- I don't see how it could ever fail. Maybe something like: the RSS handoff inserts the blueprint in a separate transaction from seeding this table, and then the bg task populates this table before we try to seed, and now every row fails to apply because it already exists?
- If the bulk write method succeeds but we failed to apply any rows, that must mean that sled already exists in the availability table, right? That again points to someone (the bg task?) managed to seed this row before we could, which means the thing we're trying to accomplish is already (presumably successfully?) done.
- If this fails, RSS handoff will fail, and it will never recover, because if there are rows already in the table, they'll still be there on every retry.
All that said: is having this check riskier than not having it, and relying on just the overall success/failure of the writes?
Contributor
Author
There was a problem hiding this comment.
Yeah -- good catch. Changed the check to be level-triggered so that we only care that the process was successful.
sunshowers
changed the base branch from
sunshowers/spr/main.9n-reconfigurator-initialize-rendezvous_sled_bp_availability-during-rss-and-tests
to
main
September 4, 2026 22:58
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For RSS, it helps avoid a gap before the initial rendezvous task run occurs. In tests, we use it to simulate what Nexus's rendezvous background task would do without having a full Nexus present.