Skip to content

Fix query field name for code verifier #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
augustuswm merged 1 commit into from
Jun 4, 2026
Merged

Fix query field name for code verifier #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions v-api/src/endpoints/login/oauth/flow/code.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ pub struct OAuthAuthzCodeExchangeBody {
pub grant_type: String,
pub code: String,
/// PKCE code verifier (RFC 7636). Required for all authorization code exchanges.
pub pkce_verifier: String,
pub code_verifier: String,
}

#[derive(Debug, Deserialize, JsonSchema, Serialize)]
Expand Down Expand Up @@ -707,7 +707,7 @@ where
&provider.name().to_string(),
client_id,
&body.redirect_uri,
&body.pkce_verifier,
&body.code_verifier,
)?;

tracing::debug!("Verified login attempt");
Expand Down Expand Up @@ -814,7 +814,7 @@ fn verify_login_attempt(
provider: &str,
client_id: TypedUuid<OAuthClientId>,
redirect_uri: &str,
pkce_verifier: &str,
code_verifier: &str,
) -> Result<(), OAuthError> {
if attempt.provider != provider {
Err(OAuthError::new(
Expand Down Expand Up @@ -845,7 +845,7 @@ fn verify_login_attempt(
match attempt.pkce_challenge.as_deref() {
Some(challenge) => {
let mut hasher = Sha256::new();
hasher.update(pkce_verifier);
hasher.update(code_verifier);
let hash = hasher.finalize();
let computed_challenge = BASE64_URL_SAFE_NO_PAD.encode(hash);

Expand Down
Loading