Fix KeyboardInterrupt leaking from Abort echo in prompt - #3813
Open
cnbei wants to merge 1 commit into
Open
Conversation
A second Ctrl-C while Command.main prints Aborted! after prompt() is cancelled could escape as an unhandled KeyboardInterrupt. Fixes pallets#3802. Co-authored-by: cnbei <baymy@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3802
Ctrl-C during click.prompt() becomes Abort, then Command.main echoes Aborted. A second SIGINT in isatty() leaks because KeyboardInterrupt is a BaseException. Catch KeyboardInterrupt around that abort echo and still sys.exit(1).
Adds test_prompt_abort_echo_survives_keyboard_interrupt. 1931 tests passed.