[rejected AI] Fix completion for attached option values - #3815
Closed
err0r4eve3 wants to merge 1 commit into
Closed
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an incomplete value is joined to a long option with
=,_resolve_incompletestrips the option prefix so the parameter can complete only the value. Bash and Zsh replace the entire current word, though, so returningalwaysfor--color=aldrops the option name.Preserve the stripped prefix and reattach it to completion items only after the input resolves to an option that accepts a value. Rebuild each item with its original type, help, and custom metadata so custom completion behavior remains intact. Add regression coverage for both an empty and a partial attached value, plus a changelog entry.
Fixes #2847
Tests:
uv run pytestuv run mypyuv run pre-commit run --files CHANGES.md src/click/shell_completion.py tests/test_shell_completion.py