feat(ext): first-time setup walkthrough on the options page#70
Merged
Conversation
Onboarding polish for the store submission (#61 Phase 1): - "First-time setup" guide at the top of the options page: deep link to github.com/new pre-filled for a private bookmarks repo, deep link to the fine-grained PAT page with the exact repository-access + Contents: read-write steps, then validate-and-save. - The guide is a <details> that auto-opens when no settings exist and collapses after a successful save. - Clearer PAT guidance: github_pat_ placeholder and a hint that the token stays in extension storage and only ever goes to api.github.com. - Saved confirmation now points at the next action (click the icon to save a page); e2e assertions updated to toContainText accordingly. Single-source change in extension-shared — both shells copy options.html at prebuild. Verified in real Chromium (7 e2e passed, fresh-profile screenshot shows the guide open). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Onboarding polish from epic #61 Phase 1: an in-extension setup walkthrough with a "create your bookmarks repo" deep link and clearer PAT guidance on the options page.
Changes
options.html): a<details>block above the form with three steps —options.ts).github_pat_…placeholder + hint that the token is stored only in this browser's extension storage and sent only to api.github.com — no gitmarks server.✓ saved — click the gitmarks icon on any page to save it. The three options-page e2e assertions moved fromtoHaveText("✓ saved")totoContainText(two of them are in skipped tests, updated for consistency; the popup-save assertion is untouched).browserimport inoptions.ts.Single-source change: both shells copy
options.htmlfromextension-sharedat prebuild, so Chrome and Firefox pick this up identically.Verification
pnpm --filter @gitmarks/extension-shared test— 127 passedpnpm typecheck— all packages cleanNotes
name/visibility/description) is best-effort — if GitHub ignores a param the link still lands on repo creation. Worth an eyeball during the next manual smoke test.Part of #61
🤖 Generated with Claude Code