fix(ext): drop dynamic innerHTML in popup; require Firefox 140 (AMO warnings)#76
Merged
Conversation
…arnings) Render the tab title via textContent/title-attribute assignment on a statically-templated element instead of interpolating escaped strings into innerHTML — the AMO validator flags any dynamic innerHTML and the escape helpers are now dead code, removed. Bump the Firefox strict_min_version to 140.0, the first version that understands data_collection_permissions, so the consent UI is guaranteed to show (current ESR is 140, so the reach cost is nil). Closes #75 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render the tab title via textContent/title-attribute assignment on a
statically-templated element instead of interpolating escaped strings
into innerHTML — the AMO validator flags any dynamic innerHTML and the
escape helpers are now dead code, removed. Bump the Firefox
strict_min_version to 140.0, the first version that understands
data_collection_permissions, so the consent UI is guaranteed to show
(current ESR is 140, so the reach cost is nil).
Closes #75
Co-Authored-By: Claude Fable 5 noreply@anthropic.com