fix: remediation respects PATH vs managed resolution order - #229
Merged
Conversation
PATH and patchloom.path win binary resolution over managed storage. Offering Install/Update managed for an outdated PATH binary left the active CLI stale. Remediation now: Update only for managed source, Settings for patchloom.path, Open Releases for PATH. Bump ovsx 1.1.1. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPI cycle 2 after #228. Test Auditor + Adversarial review of
preferredBinaryRemediationAction:patchloom.path) CLI offered Install/Update Patchloom when managed storage was available. Managed install never overrides PATH/setting, so the active binary stayed outdated after a "successful" update.source === "managed"; Settings whensource === "setting"; Open Releases for PATH.ovsx1.1.0 → 1.1.1.Test plan
npm run check(unit + coverage + package)Note
Release PR #227 (v0.4.0) remains open; not merged without explicit approval.