Skip to content

feat: pf-pagination (bottom variant) #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eyevana wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: pf-pagination (bottom variant) #2455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecf261d
feat: pf-pagination bottom variant
eyevana Mar 28, 2023
1f3d6c5
feat: leverage controller for per-page menu a11y
eyevana Mar 29, 2023
ad26eb2
chore: these changes should be on a separate PR
eyevana Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elements/pf-button/pf-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ button:hover {
:host([block]) button {
display: flex;
width: 100%;
justify-content: var(--pf-c-button--JustifyContent, center);
Copy link
Copy Markdown
Member

@bennypowers bennypowers Apr 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Copy Markdown
Contributor Author

@eyevana eyevana Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this and opened that separate PR to add the CSS var, but opting for a part on the button instead.

https://github.com/patternfly/patternfly-elements/pull/2470/files

justify-content: center;
}

/******************************
Expand Down
1 change: 0 additions & 1 deletion elements/pf-pagination/pf-pagination.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@

#container #options-menu #menu-list .menu-item {
white-space: nowrap;
--pf-c-button--JustifyContent: start;
--pf-c-button--PaddingTop: var(--pf-c-options-menu__menu-item--PaddingTop, var(--pf-global--spacer--sm, .5rem));
--pf-c-button--PaddingRight: var(--pf-c-options-menu__menu-item--PaddingRight, var(--pf-global--spacer--md, 1rem));
--pf-c-button--PaddingBottom: var(--pf-c-options-menu__menu-item--PaddingBottom, var(--pf-global--spacer--sm, .5rem));
Expand Down