Skip to content

fix(List): align block content with list markers in Firefox #12672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minwookshin wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

fix(List): align block content with list markers in Firefox #12672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/List/ListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const ListItem: React.FunctionComponent<ListItemProps> = ({
}: ListItemProps) => (
<li className={css(icon && styles.listItem, className)} {...props}>
{icon && <span className={css(styles.listItemIcon)}>{icon}</span>}
<span className={icon && css(`${styles.list}__item-text`)}>{children}</span>
{icon ? <span className={css(`${styles.list}__item-text`)}>{children}</span> : children}
</li>
);
ListItem.displayName = 'ListItem';
11 changes: 11 additions & 0 deletions packages/react-core/src/components/List/__tests__/ListItem.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { render, screen } from '@testing-library/react';
import { ListItem } from '../ListItem';
import { Content } from '../../Content';
import styles from '@patternfly/react-styles/css/components/List/list';

test('Renders with children', () => {
Expand All @@ -8,6 +9,16 @@ test('Renders with children', () => {
expect(screen.getByRole('listitem')).toHaveTextContent('List item content');
});

test('Renders block content without an inline wrapper when there is no icon', () => {
render(
<ListItem>
<Content data-testid="content">List item content</Content>
</ListItem>
);

expect(screen.getByTestId('content').parentElement).toBe(screen.getByRole('listitem'));
});

test(`Does not render with a class by default`, () => {
render(<ListItem>List item content</ListItem>);

Expand Down
4 changes: 1 addition & 3 deletions packages/react-core/src/components/List/__tests__/__snapshots__/ListItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ exports[`Matches snapshot with icon 1`] = `
exports[`Matches snapshot without icon 1`] = `
<DocumentFragment>
<li>
<span>
List item content
</span>
List item content
</li>
</DocumentFragment>
`;