Bump react-player from 2.16.1 to 3.4.0#635
Conversation
Bumps [react-player](https://github.com/cookpete/react-player) from 2.16.1 to 3.4.0. - [Release notes](https://github.com/cookpete/react-player/releases) - [Changelog](https://github.com/cookpete/react-player/blob/master/CHANGELOG.md) - [Commits](cookpete/react-player@v2.16.1...v3.4.0) --- updated-dependencies: - dependency-name: react-player dependency-version: 3.4.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zeevmoney
left a comment
zeevmoney
left a comment
There was a problem hiding this comment.
MEDIUM — breaking change not handled in repo code
react-player v3 is a full rewrite and is not backwards compatible with v2 (see the v3 migration guide). Notably the url prop was renamed to src.
This repo's PlayerWithControlls component still passes the old url prop:
docs/tutorials/player_with_controlls.js:14—url="/video/Mcdonalds-onboarding.mp4"versioned_docs/version-1.0.0/tutorials/player_with_controlls.js(same usage)
Under v3 the url prop is ignored, so these embedded players would silently fail to load the video. Before merging, update those components to use src instead of url (and review the ref/playsinline changes in the migration guide). Other v3 changes: playsinline→playsInline, wrapper defaults to undefined, progressInterval/stopOnUnmount deprecated.
If updating the call sites isn't in scope here, pin to v2 instead.
Automated review.
1 participant
Bumps react-player from 2.16.1 to 3.4.0.
Release notes
Sourced from react-player's releases.
... (truncated)
Changelog
Sourced from react-player's changelog.
... (truncated)
Commits
258fce9chore(release): 3.4.0a68f29dfix: upgrade player deps27fcd7cfix: Improve accessibility and code quality (#1985)4650cb0feat: Add disableRemotePlayback prop (#2004)e09d35fchore(release): 3.3.3c773223fix: upgrade deps + fix hls config buga9d43f1chore(release): 3.3.255cf5fefix: prevent React warnings for unknown event handler properties (#1970)10f0cdcdocs: the demo source in README.md (#1979)7018095Fix: Add share URLs to TikTok pattern matching (#1973)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)