[FEATURE] Add panel-level repeat variable model by adrianSepiol · Pull Request #32 · perses/spec

adrianSepiol · 2026-06-01T17:19:25Z

Related to: perses/perses#2936
Model for repeat variable on panel level.

ibakshay

Thank you for the PR! Added few comments.

Copilot

Pull request overview

Adds a panel-level “repeat variable” model to the dashboard layout spec so an individual grid item/panel can be repeated based on a variable, and exposes the needed layout fields in the panel editor model.

Changes:

Introduces repeatVariable as an object on grid items (TS/Go/Java/CUE) with fields like value, maxPer, and alignment.
Extends panel editor values/schema to include a layoutDefinition (width/height + optional repeat variable).
Adds Go JSON unmarshal tests for grid items containing the new repeat variable object.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ts/src/schema/panel.ts	Adds zod schemas for panel editor `layoutDefinition` and repeat variable.
ts/src/dashboard/panel.ts	Extends exported `PanelEditorValues` with `layoutDefinition`.
ts/src/dashboard/layout.ts	Adds `RepeatVariable` model and `repeatVariable` on `GridItemDefinition`.
java/src/main/java/dev/perses/spec/dashboard/Layout.java	Adds `RepeatVariable` to `GridItem`.
go/dashboard/layout.go	Adds `RepeatVariable` structs/types and `repeatVariable` on `GridItem`.
go/dashboard/layout_test.go	Adds JSON unmarshal test cases for the new repeat variable object.
cue/dashboard/layout_go_gen.cue	Updates generated CUE schema to include repeat variable object on grid items.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

ibakshay

LGTM! @AntoineThebaud Do you also want to have a look?

Gladorme · 2026-06-16T08:41:00Z

+
+export const layoutDefinitionSchema = z.object({
+  repeatVariable: repeatVariableSchema.optional(),
+  width: z.number().int().positive(),


Panel Editor is only for panel spec, layout is not really handled here (at least currently). Because JSON tab, will only output panel spec, if you do change on layout, nothing will change in JSON. Maybe we need to add two JSON tabs, if we add layout to this editor.
And it's supposing all layouts are using GridItem, that is the case currently. But I don't know if it will always be the case 🤔

After, I don't think it's a better to add a new editor just for layout. And put spec and layout in same editor can be fine.

Ping @Nexucis / @jgbernalp if have strong opinion on this

As @Gladorme points out the layout is only a property of a dashboard. Panels really should not care which layout was selected for them. We are in the process of adding a new Tab layout in addition to the Grid. I don't think we need a specific editor for layout as it would be configured visually by adding panel groups. Nothing wrong with this code but this schema should be moved to the layout.ts.

Move zod schema to layout.ts.

I don't think we need a specific editor for layout as it would be configured visually by adding panel groups

In the current state, panel repeat is not configured by panel groups, but at panel level instead

Gladorme · 2026-06-16T08:46:19Z

+
+#RepeatVariable: {
+	value:      string                   @go(Value)
+	maxPer?:    null | int               @go(MaxPer,*int)


More link to implem than spec, but what happen if there is two panels next to each other without repeat variable. And you enable it on one with maxPer: 2. Will it do 2 rows?

1 panel (without repeat), empty

panel repeat, panel repeat

maxPer refers to rows inside grid item. By default the grid item will extend it's width to full grid width when setting repeat panel on given item (inspired by grafana) but after that you can change its width and the panels will be fit into rows based on maxPer variable.

demo.mov

Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

jgbernalp · 2026-06-22T11:25:24Z

LGTM, I'll let @Gladorme approve

Gladorme · 2026-06-22T12:21:35Z

 /**
 * Panel values that can be edited in the panel editor.
 */
 export interface PanelEditorValues {


Not introduced by the PR, but this PanelEditorValues + zod schema (buildPanelEditorSchema + panelEditorSchema) should be at the panel editor level in perses/shared. Make no sense to have UI interface/code here 🤔 I will need to move it later

jgbernalp · 2026-06-29T12:38:29Z

@adrianSepiol I checked again and the structure looks good to me. The repeat variable is part of the layout item rather than the panel itself, which I think is the right direction. Other than @Gladorme comments regarding the misplaced interface, that is a pre existing issue, we can proceed.

Gladorme · 2026-06-29T14:03:55Z

Ok for structure me too, except for the panel editor value.
It need to be moved, I don't think we want to have display settings in panel editor, it's not the right place to me.

…cern Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

adrianSepiol force-pushed the feat/panel-level-repeat branch from 0c5361e to 0e593be Compare June 1, 2026 17:20

adrianSepiol changed the title ~~Feat/panel level repeat~~ [FEATURE] Add panel-level repeat variable model Jun 1, 2026

adrianSepiol mentioned this pull request Jun 1, 2026

[FEATURE] Add panel-level repeat variable support perses/shared#149

Open

6 tasks

adrianSepiol force-pushed the feat/panel-level-repeat branch 2 times, most recently from 5289d45 to 73a8a20 Compare June 10, 2026 06:53

ibakshay reviewed Jun 11, 2026

View reviewed changes

Comment thread java/src/main/java/dev/perses/spec/dashboard/Layout.java Outdated

Comment thread ts/src/schema/panel.ts Outdated

Comment thread ts/src/dashboard/panel.ts Outdated

ibakshay requested a review from Copilot June 11, 2026 09:10

Copilot started reviewing on behalf of ibakshay June 11, 2026 09:11 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

adrianSepiol force-pushed the feat/panel-level-repeat branch from 73a8a20 to 954d1d9 Compare June 11, 2026 10:07

ibakshay requested a review from Copilot June 11, 2026 11:08

Copilot started reviewing on behalf of ibakshay June 11, 2026 11:08 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread ts/src/schema/panel.ts Outdated

Comment thread ts/src/dashboard/panel.ts Outdated

adrianSepiol force-pushed the feat/panel-level-repeat branch 2 times, most recently from f88e3d5 to 1da3efd Compare June 11, 2026 12:21

ibakshay requested a review from Copilot June 11, 2026 15:39

Copilot started reviewing on behalf of ibakshay June 11, 2026 15:40 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread go/dashboard/layout.go

Comment thread java/src/main/java/dev/perses/spec/dashboard/Layout.java

[FEATURE] Add panel-level repeat variable model

ea0c4d0

Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

adrianSepiol force-pushed the feat/panel-level-repeat branch from 1da3efd to ea0c4d0 Compare June 12, 2026 06:38

ibakshay approved these changes Jun 12, 2026

View reviewed changes

Gladorme reviewed Jun 16, 2026

View reviewed changes

[IGNORE] move layout zod schema to separate file

1d92d6c

Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

jgbernalp reviewed Jun 22, 2026

View reviewed changes

Comment thread ts/src/schema/layout.ts Outdated

[IGNORE] type layout schema

6b9fdfd

Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

Gladorme reviewed Jun 22, 2026

View reviewed changes

[ENHANCEMENT] remove layout editor schema from spec as it is a UI con…

1770d5c

…cern Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>

Uh oh!

Conversation

adrianSepiol commented Jun 1, 2026

Uh oh!

ibakshay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

ibakshay left a comment

Choose a reason for hiding this comment

Uh oh!

Gladorme Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

jgbernalp Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

adrianSepiol Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

Gladorme Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gladorme Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

adrianSepiol Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jgbernalp commented Jun 22, 2026

Uh oh!

Gladorme Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgbernalp commented Jun 29, 2026

Uh oh!

Gladorme commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gladorme Jun 22, 2026 •

edited

Loading

Gladorme Jun 22, 2026 •

edited

Loading

Gladorme commented Jun 29, 2026 •

edited

Loading