Skip to content

Parse react-frame-component as CommonJS so 5.3 bundles correctly #10467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpage wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −9
Open

Parse react-frame-component as CommonJS so 5.3 bundles correctly #10467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11f1439
Parse react-frame-component as CommonJS so 5.3 bundles correctly
dpage Sep 28, 2026
655a352
Bump react-frame-component to 5.3.2.
dpage Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
"react-dom": "^19.2.8",
"react-draggable": "^4.7.1",
"react-dropzone": "^15.0.0",
"react-frame-component": "~5.2.6",
"react-frame-component": "~5.3.2",
"react-leaflet": "^4.2.1",
"react-new-window": "^1.0.1",
"react-resize-detector": "^12.3.0",
Expand Down
8 changes: 8 additions & 0 deletions web/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,14 @@ module.exports = [{
resolve: {
fullySpecified: false
},
},{
// react-frame-component 5.3 declares "type": "module" but maps its
// "require" export to a UMD build. Babel compiles our imports to
// require(), so webpack picks the UMD file and, honouring the package
// type, parses it as ESM, where the UMD wrapper finds no exports object
// and exports nothing. Parse it as CommonJS/auto so the UMD works.
test: /[\\/]node_modules[\\/]react-frame-component[\\/].*\.js$/,
Comment thread
coderabbitai[bot] marked this conversation as resolved.
type: 'javascript/auto',
},{
test: /\.tsx?$|\.ts?$|\.jsx?$/,
exclude: [/node_modules/, /vendor/],
Expand Down
16 changes: 8 additions & 8 deletions web/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13897,14 +13897,14 @@ __metadata:
languageName: node
linkType: hard

"react-frame-component@npm:~5.2.6":
version: 5.2.7
resolution: "react-frame-component@npm:5.2.7"
"react-frame-component@npm:~5.3.2":
version: 5.3.2
resolution: "react-frame-component@npm:5.3.2"
peerDependencies:
prop-types: ^15.5.9
react: ">= 16.3"
react-dom: ">= 16.3"
checksum: 10c0/e138602aa98557c021ae825f51468026c53b9939140c5961d5371b65ad07ff9a5adaf2cd4e4a8a77414a05ae0f95a842939c8e102aa576ef21ff096368b905a3
prop-types: ^15.8.1 || ^16.0.0 || ^17.0.0 || ^18.0.0
react: ">= 16.8 || ^17.0.0 || ^18.0.0 || ^19.0.0"
react-dom: ">= 16.8 || ^17.0.0 || ^18.0.0 || ^19.0.0"
checksum: 10c0/c158117f832c82ee4e17584b1a8a90ac2080d8fdf8bf9708c1fea5dc38052763e71f378cc09e1e82b8cf67715d9933dde64c011cf7331d2edc33b3383f711206
languageName: node
linkType: hard

Expand Down Expand Up @@ -14527,7 +14527,7 @@ __metadata:
react-dom: "npm:^19.2.8"
react-draggable: "npm:^4.7.1"
react-dropzone: "npm:^15.0.0"
react-frame-component: "npm:~5.2.6"
react-frame-component: "npm:~5.3.2"
react-leaflet: "npm:^4.2.1"
react-new-window: "npm:^1.0.1"
react-resize-detector: "npm:^12.3.0"
Expand Down
Loading