Conversation
sgrif
commented
Jun 10, 2026
| ); // 32x on my M1 | ||
|
|
||
| assert!(faster > 10.0); | ||
| assert!(faster > 9.0); |
Contributor
Author
There was a problem hiding this comment.
See y'all when I have to lower this to 8
levkk
approved these changes
Jun 10, 2026
levkk
left a comment
levkk
left a comment
Collaborator
There was a problem hiding this comment.
Red is good. Green is evil. This is good.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
The deleted tests are either redundant with unit tests in the refactored code, or sufficiently covered by integration tests. CodeCov will still complain This doesn't quite delete as much as I'd like. Surprisingly, we still call `buffer.aggregate` on queries that absolutely should not be doing aggregation, such as direct-to-shard and explain queries. The old code treated missing helper columns as an indication we're running one of those, instead of an error condition. Direct to shard is easy to filter out, but explain needs a bit more digging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleted tests are either redundant with unit tests in the refactored code, or sufficiently covered by integration tests. CodeCov will still complain