Skip to content

[NFR]: Reduce coupling #62

Closed
Closed

Description

@niden

Reduce coupling between components, ensure single source of truth for elements in the code i.e. no two areas defining the same thing.

  • Request history: History\HistoryRecorder holds the workflow and Core::createHistory() creates
    it. ResponseListener takes one recorder in place of three arguments, and the providers no longer
    duplicate the boot steps. CONTROLLER_NAMESPACE moves to Mvc\HistoryListener.
  • Panel contract: The PHP and JavaScript tests read the same fixture, and static analysis rejects an
    unknown panel name. The unused $icon and widget.icon are removed, and private shapes move from
    DebugBarTypes to their collectors.
  • Redaction: Redactor::redactUri() masks sensitive query values in the request panel and in
    stored history, and LoggerCollector redacts the log context. Query bindings are not redacted, and the
    docs state this.
  • Debug facade: The logger adapters read the active bar at log time, so you can create them before
    boot. Core::getBar() replaces the static read in the providers.
    • Response rules: RequestContext replaces three copies of the client address rule.
      Injector::isHtml() is separate from the injection rules, and the ADR debug page uses it.
  • Worker limit: The docs state the effect of a long-lived worker on request history.

Activity

  1. self-assigned this
    on Nov 5, 2026
  2. added theissue type on Nov 5, 2026
  3. moved this from Backlog to In Progress in Phalcon v5on Nov 5, 2026
  4. niden commented on Nov 5, 2026

    @niden
    SponsorMemberAuthor

    Resolved in #63

  5. moved this from In Progress to Implemented in Phalcon v5on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

  • Status
    Implemented

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions