Skip to content

T64 align icons drawings - #65

Merged
niden merged 2 commits into
masterfrom
T64-align-icons-drawings
Nov 5, 2026
Merged

niden merged 2 commits into
masterfrom
T64-align-icons-drawings

Conversation

@niden

@niden niden commented Nov 5, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

DebugBarTypes lists the icon names as icon_type, so static analysis rejects an unknown indicator.icon. A test keeps the list equal to the drawings in debugbar.js. An indicator with an unknown icon name now shows no icon, not the gears.

Thanks

niden added 2 commits November 5, 2026 09:59
Assisted-by: Claude Code
Assisted-by: Claude Code
@niden niden added the enhancement New feature or request label Nov 5, 2026
@niden niden self-assigned this Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Code Metrics Report

master (d7f8475) #65 (68c34a4) +/-
Coverage 100.0% 100.0% 0.0%
Test Execution Time 4s 4s 0s
Details
  |                     | master (d7f8475) | #65 (68c34a4) | +/-  |
  |---------------------|------------------|---------------|------|
  | Coverage            |           100.0% |        100.0% | 0.0% |
  |   Files             |               83 |            83 |    0 |
  |   Lines             |             2002 |          2002 |    0 |
  |   Covered           |             2002 |          2002 |    0 |
  | Test Execution Time |               4s |            4s |   0s |

Code coverage of files in pull request scope (0.0% → 0.0%)

Files Coverage +/- Status
src/DebugBar/DebugBarTypes.php 0.0% 0.0% modified

Reported by octocov

@niden
niden merged commit 4078ee2 into master Nov 5, 2026
24 checks passed
@niden
niden deleted the T64-align-icons-drawings branch November 5, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant