Skip to content

fix(windows): remove stale bundled Node dependencies before installation #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
Oct 10, 2026
Merged

fix(windows): remove stale bundled Node dependencies before installation #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src-tauri/src/bundle/windows/nsis/installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,10 +1137,24 @@ Function SetupPhcode

FunctionEnd

; Bundled dependencies are one release unit. Overlaying upgrades leaves removed nested
; packages on disk, where Node can resolve them instead of the new release's dependencies.
; Never defer this cleanup until reboot: that would allow a mixed dependency tree to launch.
!macro CleanBundledNodeResources
${If} ${FileExists} "$INSTDIR\src-node\*.*"
ClearErrors
RMDir /r "$INSTDIR\src-node"
${If} ${Errors}
Abort "$(unableToUninstall)"
${EndIf}
${EndIf}
!macroend

Section Install
SetOutPath $INSTDIR

!insertmacro CheckIfAppIsRunning
!insertmacro CleanBundledNodeResources

; Copy main executable
File "${MAINBINARYSRCPATH}"
Expand Down
Loading