Repository navigation
Fix PHPStan 2.3.2 failure in ArrayDeclarationSniff - #93
Merged
Merged
Conversation
PHPStan 2.3.2 reports the repeated `multiLineIndentationMode === 'assoc'` check inside the item loop as always true (identical.alwaysTrue), which fails the stan job on every branch. The property can hold other values there, so it is a false positive, but the loop only needs the result of the check made before it. Evaluating it once removes the duplicate and the report without changing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI now installs PHPStan 2.3.2, which reports
ArrayDeclarationSniff.php:616asidentical.alwaysTrueand fails the stan job on every branch, including #89, #90, #91 and #92.It is a false positive (the property can hold other strings at that point), but the loop only needs the value of the check made just before it, so the condition is now computed once and reused. No behavior change.