Repository navigation
Conversation
|
Important Review skippedToo many files! This PR contains 268 files, which is 168 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
Changelog✅ Contribution check passed. Head: Base: Contribution: 2 new valid fragment(s). Policy: ordinary.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Rigorous review requestedThis pull request is ready for the dedicated
Review focus
Sample changed files
Suggested prompt |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71cd59eafb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
351b861 to
55341a8
Compare
|
🚀 Preview is available for this pull request. |
Consumer alignment reconciliation and Code Standards migration inventory — 2026-10-25Scope acceptance: this queue owns consumer skill-source alignment and framework follow-up only. DevTools #376, Testing #380 and the dedicated Code Standards implementation remain with their existing owners. No duplicate implementation, worktree competition, new card or merged-PR reopening was started. The detailed, public framework legacy-skill audit is recorded on framework #21, including installed/published provenance, per-skill disposition, role dependencies, test scenarios and exact blockers. Current 14-consumer PR/head reconciliationThese are freshly queried PR states, not assumptions from the previous rollout report. Seven are merged and seven remain open.
The nine repaired consumers are clock, config, container, defer, enum, fork, http-factory, http-message and iterators. Their observed PR heads still equal their published corrective commits. Those corrections passed complete Actual configuration inventoryC — twelve component profiles. Each has a project Preserve all of these when substituting the tool:
F — framework. It has the same PHPDoc intent plus the deliberate N — phpdoc-bootstrap-template. Its alignment PR adds no project PHP-CS-Fixer/ECS/Rector profile. Do not manufacture a configuration-removal change there. No project-local The twelve inspected component installations use DevTools Next concrete steps and gates
Executed in this audit: remote PR/head queries; installed Composer/source inspection; comparison of twelve executable profile bodies; framework tracked/generated/role inventory; complete six-file Changelog payload comparison against the published tag; review of existing comments before posting these findings. Not executed: Code Standards consumer installation, replacement patch, new lifecycle test, full suite rerun for a new candidate, repository deletions, new commit/push/PR or publication. The blockers are an owner-supplied release contract and concrete role/sync/equivalence dependencies, not an additional human decision request. Changelog-only local follow-upThe canonical framework audit now contains executed lifecycle scenarios. The candidate supplier role at this PR's A disposable LLM Skills 1.15.0 consumer passed normal install, strict validation, explicit sync, reinstall and repeated sync without creating Custodian dependency: reconcile the supported role/sync distribution for the consumer's selected version, including the candidate role's Only local synthetic fixture/test files and these coordination comments changed; no repository code patch, commit/push, new PR, hook bypass, merge, pipeline release or global installation occurred. |
Related Issue
User-requested DevTools 2.0 distribution redesign. The migration guide proposes follow-up triage for #195 and #197; this PR does not close those issues automatically.
Motivation / Context
Libraries used by DevTools need to consume its tooling without requiring DevTools in their own Composer graph. Running the CLI externally and installing skills independently removes that cycle and allows responsibilities to move gradually to their owning packages.
Changes
fast-forward-*skills underresources/skills, declare their source, and document LLM Skills installation through installed Composer donors or pinned GitHub sources.phpro/grumphp-shim:2.26.0 grumphp. Select the binary explicitly and allow 600 seconds for the complete coverage/report pipeline.mainat84e154046e07cafa6ac09a9e12434b1ff5dcb5e0, preserving its autoload.files, Pages, preview, and exit-status fixes.Verification
Current skill-source increment (
4f3cf00517fb64adbaa26689b64431d27b40266d)skills.jsonwithfast-forward/*Composer trust,trusted-replace, automatic sync, the canonical local directory without a package override, and the Changelog GitHub source at^0.4.0without a redundant skill allowlist.llm/skills:^1.15and its specific plugin permission so ordinary contributor installs can restore the configured sources. Keep generated.agents/skillsignored; the former tracked external Changelog payload is preserved locally and reconstructed by the manager.composer dev-tools: 713 tests, 2,578 assertions, zero failures/errors/warnings/skips; 90.77% line coverage. Rector, PHPDoc, ECS, metrics and rendered API/user documentation passed.0.4.0validates all 13 pending fragments, including the committed--since=origin/maincomparison. Normal commit completed without bypassing hooks.These local results apply to the current head. Hosted PHP 8.3/8.4/8.5 tests, Dependency Health, CodeQL, Wiki generation, rendered reports/PR preview and exact-head Changelog checks also passed on this head. Final inline-thread inspection found no unresolved feedback; the single earlier PHP-CS-Fixer bootstrap thread is resolved. The earlier migration review does not approve this new commit; maintainer review remains separate.
Earlier migration verification
55341a86a10564c4c9ed32ac3de92542b8a63f25, independently reviewed; clean worktree and reviewed treef4eb9969b2944a1549ae613aa60f3477d82e9e4d.git commitpassed both installed hooks through real CPX/GrumPHP, with no hook bypass. The mandatory Composer script ran the full DevTools gate: 713 tests, 2,578 assertions, zero errors/failures/skips; Rector, PHPDoc, ECS, reports, metrics, and API docs passed.Documentation / Generated Output
Changelog
.changelog/dev-tools-2-external-runtime.mddeclares the major change.Reviewer Notes
Consumer
2.0.0examples require release availability verification before adoption. No real consumer migration or package release is included. CPX separates dependency resolution/processes; it does not namespace-scope classes loaded into the same PHP process, so integration compatibility fixtures remain necessary.The runtime still bundles most development tools as package requirements. Optional profiles and on-demand tool installation remain follow-up behavior changes, proposed as separate PRs. LLM Skills setup in this increment is development-only; consumer execution still does not install the manager or activate a host. No merge or auto-merge has been requested.