Skip to content

fix: honor explicit Rector config and PHPDoc paths - #393

Merged
coisa merged 2 commits into
mainfrom
fix/audit-tool-scope
Oct 21, 2026
Merged

coisa merged 2 commits into
mainfrom
fix/audit-tool-scope

Conversation

@coisa

@coisa coisa commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Related Issue

Closes #388

Changes

  • Resolve the caller's Rector --config instead of always selecting rector.php; require a value when supplied.
  • Accept multiple PHPDoc paths, validate before writing .docheader, and pass distinct arguments after -- to both fixers.
  • Preserve configured scope when no paths are given. PHP-CS-Fixer intersection retains configured exclusions; Rector retains skip rules.
  • Real ProcessBuilder argv regressions cover custom config, files, directories, multiple paths, spaces, option-like filenames, missing-path failure and no fallback.

Verification

  • PHP8.4.26 lint and git diff --check passed.
  • Actual RefactorCommand recording harness RED→GREEN: custom/limited.php ignored before, honored after.
  • Independent test-guardian review completed.
  • Full command PHPUnit and underlying fixer --fix integration unavailable locally because vendor dependencies are absent; prior dependency-download denial respected. Hosted CI required. Recording tests do not claim actual underlying fixer mutation tests.
  • Official contracts consulted: https://cs.symfony.com/doc/usage.html and https://getrector.com/documentation/cli-options .

Documentation / Generated Output

Updated refactor/phpdoc documentation and help. No consumer files changed.

Changelog

Added .changelog/explicit-tool-scope.md (fixed/patch).

Reviewer Notes

No extraction, merge, release or PR376 changes. Initial commit approval failed technically without execution; retried once following the user's specific renewed authorization.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T18:58:51.722084Z 3ce2bd8 New commits
🔒 Security Review ✅ Completed 2026-10-21T19:01:54.412076Z 3ce2bd8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8a2ddf0b-4d38-401d-9d5c-9131170e45bb
📥 Commits

Reviewing files that changed from the base of the PR and between c9e5b3a and 3ce2bd8.

📒 Files selected for processing: 7
  • .changelog/explicit-tool-scope.md
  • docs/commands/phpdoc.rst
  • docs/commands/refactor.rst
  • src/Console/Command/PhpDocCommand.php
  • src/Console/Command/RefactorCommand.php
  • tests/Console/Command/PhpDocCommandTest.php
  • tests/Console/Command/RefactorCommandTest.php
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Changelog

✅ Contribution check passed.

Head: 11a123f8c0280bba3d27238a78bd0d8d9c43b279

Base: e81c4600043b8cf38a57f7cbcf274308edbc2582

Contribution: 1 new valid fragment(s). Policy: ordinary.

  • explicit-tool-scope.md — fixed, patch

    Honor explicit Rector configuration and forward PHPDoc file/directory selections to both underlying tools. Preserve configured scope when no paths are given and reject missing explicit PHPDoc paths before writing or running fixers.

@github-actions

Copy link
Copy Markdown
Contributor

@coisa
coisa merged commit 5ea0eee into main Oct 21, 2026
28 of 30 checks passed
@coisa
coisa deleted the fix/audit-tool-scope branch October 21, 2026 18:57
@github-project-automation github-project-automation Bot moved this from Backlog to Released in PHP Fast Forward Project Oct 21, 2026
github-actions Bot added a commit that referenced this pull request Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

Honor explicit Rector configuration and PHPDoc path selection

1 participant