[Sync-EN] Document the imagick legacy parameter and clarify bestfit - #1799
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Document the imagick legacy parameter and clarify bestfit#1799lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the four
reference/imagick/imagick/resize pages with php/doc-en#5056.legacyparameter is documented onadaptiveResizeImage(),cropThumbnailImage(),resizeImage()andscaleImage(): when true the calculations keep the small rounding bug Imagick had before 3.4.0, when false they match the ImageMagick command-line tools. Each page gains the matching "PECL imagick 3.4.0" changelog row, andcropThumbnailImage()gains a changelog section, which it had none.bestfitis described as fitting the image within the given dimensions while preserving the aspect ratio, instead of "whether to fit the image inside a bounding box" or "optional fit parameter".scaleImage()had three empty parameter descriptions (columns,rows,bestfit); they are filled in.refentryelements putxml:idbeforexmlns, and the three changeloginformaltables are no longer wrapped in apara, as upstream.EN-Revision bumped to 2fae40e40323696cab1d4108c8cfb3a424321a88 on the four files.
Fixes: #1652