Fix flaky timezone test fixture (GH-18624)

[hakre]

As documented in RunningTests, tests have to be written to be independent of any php.ini file.

Without specifying the timezone, the var_dump() will make use of the default timezone that may not be the expected "UTC" timezone.

This renders the test-cases flaky and will make them fail if the date.timezone is different from the string "UTC".

Fix is to interpolate the timezone in the test fixture or to set date.timezone to UTC.

fix-up-of: GH-18624

[hakre]

@derickr This is the ext/date part from #20035, rebased. You had approved this previously – could you take another look? Thanks.

[iluuu1994]

I see there's this:

php-src/run-tests.php

Lines 187 to 190 in d34c09f

	// If timezone is not set, use UTC.
	if (ini_get('date.timezone') == '') {
	date_default_timezone_set('UTC');
	}

But that's not effective for the processes spawned from run-tests.php. Maybe that should just be added to the $ini_overwrites array here:

php-src/run-tests.php

Line 269 in d34c09f

$ini_overwrites = [

[hakre]

@iluuu1994 thank you for looking. hmm, I only now specifically about

https://github.com/php/php-src/blob/d34c09fd3294e2194d5034138ab9178df20552a9/run-tests.php#L275C10-L275C36

having a RFC vote for it's default value in run-tests.php (ref: "If fatal_error_backtraces defaults to 1, default value in run-tests.php" in https://wiki.php.net/rfc/error_backtraces_v2#proposed_voting_choices) for that value "0".

and thinking: instead of patching individual tests the $ini_overwrites is likely a better approach for automated testing. The docs could reflect that, too, because of them I was a bit under the impression this "needs" to be done on the individual test-case, but UTC for default test-output sounds reasonable to me - especially if individual test cases can override it again (I need to double-check that, which I could do on my box both happy and counter-check with the test-case here).

And while I just wanted to ask about the branch to PR against the change of $ini_overwrites, I'm seeing I've mixed it up here again for this patch which should be PHP-8.3. Fixing that now and then see how far I'm coming.

[iluuu1994]

IMO, $ini_overwrites is the right fix. I think this should target 8.4. 8.3 is in security mode and while we do now backport test fixes to keep CI happy, this doesn't fall into that category.

[hakre]

closing in favor of #21729