odbc: Quote spaces in UID/PWD appended to connection string#22791
Open
NattyNarwhal wants to merge 1 commit into
Open
odbc: Quote spaces in UID/PWD appended to connection string#22791NattyNarwhal wants to merge 1 commit into
NattyNarwhal wants to merge 1 commit into
Conversation
iliaal
approved these changes
Jul 17, 2026
iliaal
left a comment
iliaal
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Nit: maybe add a test for the space case to ext/odbc/tests/odbc_utils.phpt?
Drivers have no standard parsing, and may react weirdly to spaces in a connection string. When we append the UID/PWD parameters for the user and pass parameters of `odbc_(p)connect` or the PDO constructor, add spaces to the list of characters that require quoting. This fixes issues related to significant whitespace possibly not being parsed in a username or password, or having whitespace mangle parsing of a connection string. Note that there is no security impact because in order to do something interesting, you must be able to control the ';=' characters, and we already quote in those cases.
NattyNarwhal
force-pushed
the
odbc-spaces-quoted-8.4
branch
from
July 17, 2026 18:12
de6c890 to
6af9270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drivers have no standard parsing, and may react weirdly to spaces in a connection string. When we append the UID/PWD parameters for the user and pass parameters of
odbc_(p)connector the PDO constructor, add spaces to the list of characters that require quoting.This fixes issues related to significant whitespace possibly not being parsed in a username or password, or having whitespace mangle parsing of a connection string. Note that there is no security impact because in order to do something interesting, you must be able to control the ';=' characters, and we already quote in those cases.