Skip to content

sapi: Remove sapi_terminate_process - #23524

Open
NattyNarwhal wants to merge 1 commit into
php:masterfrom
NattyNarwhal:sapi-terminate-process-removal
Open

sapi: Remove sapi_terminate_process#23524
NattyNarwhal wants to merge 1 commit into
php:masterfrom
NattyNarwhal:sapi-terminate-process-removal

Conversation

@NattyNarwhal

Copy link
Copy Markdown
Member

This is unused; this is a vestige of 6c15837 and 45e327a, which set up some timeout code which was removed in 650c1c0. Remove this useless function from SAPIs.

This is unused; this is a vestige of 6c15837
and 45e327a, which set up some timeout code
which was removed in 650c1c0. Remove this
useless function from SAPIs.
@NattyNarwhal
NattyNarwhal force-pushed the sapi-terminate-process-removal branch from ce7b68d to fcbec48 Compare August 31, 2026 22:21

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for #23525 I agree but maybe we should wait for the branch cut so that other SAPIs don't need adapting so close to 8.6?

@LamentXU123

Copy link
Copy Markdown
Member

I agree. Generally we might not want ABI breaks after beta versions.

@NattyNarwhal

Copy link
Copy Markdown
Member Author

Let's hold off on both until the branch then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants