ext/intl: report argument #3 ($variant) for an invalid IDNA variant - #23533
Merged
Conversation
php_intl_idn_handoff() takes domain, flags, variant, so the variant check must report argument 3; it hardcodes 2, which makes idn_to_ascii() and idn_to_utf8() blame $flags for a value carried by $variant.
devnexen
reviewed
Sep 2, 2026
Member
|
lgtm otherwise |
The message concatenated PRId32 as a literal instead of using it as a conversion, so it read "must be less than d bytes" and INT32_MAX was never printed.
devnexen
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_intl_idn_handoff()parses$domain,$flags,$variant, so the variant check must report argument 3. It hardcodes 2, soidn_to_ascii()andidn_to_utf8()blame$flagsfor a value that was passed as$variant.Before:
After:
Only the error message changes. The existing test is updated and a named-argument case is added, where the wrong number was the most misleading.