Repository navigation
Conversation
iluuu1994
reviewed
Oct 18, 2026
| zend.max_allowed_stack_size=-1 | ||
| --SKIPIF-- | ||
| <?php | ||
| if (!function_exists('posix_setrlimit') || !defined('POSIX_RLIMIT_STACK')) { |
Member
There was a problem hiding this comment.
Is the if (getenv('SKIP_MSAN')) { check missing here?
Member
Author
There was a problem hiding this comment.
I dropped it as it doesn't affect just MSAN. PowerPC under ASAN also fails, happy to rework the check.
Member
There was a problem hiding this comment.
It reads a bit oddly because it's checking for neither MSan nor PowerPC. You might use SKIP_ASAN which also applies to MSan.
Girgias
force-pushed
the
8.6-fix-msan-powerpc
branch
from
October 18, 2026 15:56
1d2c2f7 to
9a573d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Nightly CI for the MSAN/PowerPC jobs.
Partly apply the MSAN fix from master and make it more general.