Repository navigation
Fix macOS CI - #24409
Fix macOS CI#24409
Conversation
Fixing "invalid cpu feature string for builtin" errors that started to appear on Apple Clang 17.0.0 (cherry picked from commit 772479e)
There was a problem hiding this comment.
This started to enable ARM for 8.2 and 8.3. Is this intentional or should macOS be skipped entirely for these?
There was a problem hiding this comment.
Yes, that is intentional, dropping macOS entirely might cause regressions for those versions.
|
Ping @LamentXU123 |
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM, assuming tests pass. We could clean up .github/workflows/test-suite.yml now that arch is always ARM64 but it's not a prerequisite. Thank you!
LamentXU123
left a comment
LamentXU123
left a comment
There was a problem hiding this comment.
I hope brew update can solve the zip problem.
|
@LamentXU123 Current Windows libzip 1.12 build has the patch for the torrentzip bug. Once that is upgraded to 1.12.1 and then we can merge these, else it will start failing on Windows. |
* PHP-8.6: Fix macOS CI (php#24409)
|
@shivammathur I see. Could you take a look at the Unix fix #24358 ? |
* PHP-8.2: Fix macOS CI (php#24409)
* PHP-8.3: Fix macOS CI (php#24409)
* PHP-8.4: Fix macOS CI (php#24409)
* PHP-8.5: Fix macOS CI (php#24409)
6 participants
Run
brew updatebefore installing dependencies so that we get the latest version.This will fix the libzip test failure.
https://github.com/php/php-src/actions/runs/39086607634/job/117554603223#step:9:86
Drop intel based macOS runners from CI. Homebrew has moved support for intel macs to a Tier 3 configuration i.e. they no longer do builds for that.
Ref: https://brew.sh/2026/09/13/homebrew-7.0.0/
Backport the Apple Clang 17+ ARM64 build fix from Fix build on Apple Clang 17+ #18629.