Repository navigation
Conversation
…ent strings. A numeric string such as "1e999999999" made ICU expand every digit outside ZendMM, ignoring memory_limit. Strings in exponent notation are now rejected, so the output stays proportional to the input length.
LamentXU123
approved these changes
Oct 20, 2026
Member
|
Can |
iliaal
requested changes
Oct 22, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
I think we probably should handle the scale/* case here too as it has the same type of issue:
$f = IntlNumberFormatter::createFromSkeleton('precision-unlimited scale/1e3000000', 'en_US');
var_dump(strlen($f->format(1))); // int(4000001)
var_dump(strlen($f->format(1.0))); // int(4000001)
var_dump(strlen($f->format('1'))); // int(4000001)
Member
Author
|
completely forgot this PR since last days, I think I have changes locally |
iliaal
approved these changes
Oct 22, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
Looks good now, thanks for the scale/ fix.
Perhaps worth mentioning the scale/ fix in UPGRADING as well?
LamentXU123
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ent strings.
A numeric string such as "1e999999999" made ICU expand every digit outside ZendMM, ignoring memory_limit. Strings in exponent notation are now rejected, so the output stays proportional to the input length.