Fix GH-24491: Static method stream error handler replaces pending exception

Zend/tests/zpp/gh24491.phpt

@@ -0,0 +1,24 @@
+--TEST--
+GH-24491: Callable error string leaks when an exception is thrown during zpp
+--FILE--
+<?php
+set_error_handler(function (int $errno, string $errstr) {
+    throw new Exception($errstr);
+});
+
+class A {
+    public static function foo() {}
+
+    public static function test() {
+        register_shutdown_function(['self', 'foo']);
+    }
+}
+
+try {
+    A::test();
+} catch (Exception $e) {
+    echo $e->getMessage(), "\n";
+}
+?>
+--EXPECT--
+Use of "self" in callables is deprecated

Zend/zend_API.c

@@ -1096,6 +1096,9 @@ static zend_result zend_parse_arg(uint32_t arg_num, zval *arg, va_list *va, cons
 	zend_expected_type expected_type = zend_parse_arg_impl(arg, va, spec, &error, arg_num);
 	if (expected_type != Z_EXPECTED_LAST) {
 		if (EG(exception)) {
+			if (error && (expected_type == Z_EXPECTED_FUNC || expected_type == Z_EXPECTED_FUNC_OR_NULL)) {
+				efree(error);
+			}
 			return FAILURE;
 		}
 

ext/standard/tests/streams/gh24491.phpt

@@ -0,0 +1,31 @@
+--TEST--
+GH-24491 (Stream error_handler given as 'Class::method' turns the real exception into a TypeError)
+--FILE--
+<?php
+class H {
+    public static function handle(array $errors): void {
+        echo "handler called\n";
+    }
+}
+
+function run(array $options): void {
+    try {
+        fopen('/nonexistent/dir/file', 'r', false, stream_context_create(['stream' => $options]));
+    } catch (Throwable $e) {
+        echo $e::class, ": ", $e->getMessage(), "\n";
+        var_dump($e->getPrevious());
+    }
+}
+
+run(['error_mode' => StreamErrorMode::Exception, 'error_handler' => 'H::handle']);
+
+set_error_handler(function (int $errno, string $errstr) {
+    throw new ErrorException($errstr);
+});
+run(['error_handler' => ['H', 'handle']]);
+?>
+--EXPECT--
+StreamException: Failed to open stream: No such file or directory
+NULL
+ErrorException: fopen(): Failed to open stream: No such file or directory
+NULL

main/streams/stream_errors.c

@@ -370,7 +370,9 @@ static void php_stream_call_error_handler(const zval *handler, zval *errors_arra
 	char *is_callable_error = NULL;
 
 	if (!zend_is_callable(handler, &fcc, &is_callable_error)) {
-		zend_type_error("stream error handler must be a valid callback, %s", is_callable_error);
+		if (!EG(exception)) {
+			zend_type_error("stream error handler must be a valid callback, %s", is_callable_error);
+		}
 		efree(is_callable_error);
 		return;
 	}