Skip to content

Fix GH-23876: JSON_INVALID_UTF8_IGNORE and JSON_INVALID_UTF8_SUBSTITUTE are mutually exclusive #24560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HoneyTyagii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GH-23876: JSON_INVALID_UTF8_IGNORE and JSON_INVALID_UTF8_SUBSTITUTE are mutually exclusive #24560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/json/json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,11 @@ PHP_FUNCTION(json_decode)
RETURN_THROWS();
}

if ((options & PHP_JSON_INVALID_UTF8_IGNORE) && (options & PHP_JSON_INVALID_UTF8_SUBSTITUTE)) {
zend_argument_value_error(4, "JSON_INVALID_UTF8_IGNORE and JSON_INVALID_UTF8_SUBSTITUTE are mutually exclusive");
RETURN_THROWS();
}

/* For BC reasons, the bool $assoc overrides the long $options bit for PHP_JSON_OBJECT_AS_ARRAY */
if (!assoc_null) {
if (assoc) {
Expand Down
Loading