Repository navigation
Conversation
jorgsowa
force-pushed
the
fix-header-len-truncation
branch
2 times, most recently
from
October 22, 2026 17:14
2d1c506 to
07525f1
Compare
A Set-Cookie line of 4 GiB or more had its length truncated, so sapi_header_op() did not check the whole line for new lines and NUL bytes.
jorgsowa
force-pushed
the
fix-header-len-truncation
branch
from
October 22, 2026 18:16
07525f1 to
c142cf2
Compare
jorgsowa
marked this pull request as ready for review
October 22, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setcookie()and theContent-Typebranch ofsapi_header_op()cast the size_t header length to uint32_t, silently truncating headers of 4 GiB or more.Follow-up of #24540