Skip to content

[skip ci] Add policy for duplicate PRs - #24613

Merged
LamentXU123 merged 5 commits into
php:masterfrom
LamentXU123:docs-check-duplicate-prs
Oct 24, 2026
Merged

LamentXU123 merged 5 commits into
php:masterfrom
LamentXU123:docs-check-duplicate-prs

Conversation

@LamentXU123

Copy link
Copy Markdown
Member

I hope this can stop agents from racing PRs <(_ _)>

@LamentXU123
LamentXU123 requested a review from iluuu1994 October 23, 2026 17:53

@ndossche ndossche left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me but wait for more people

Comment thread CONTRIBUTING.md Outdated
@iluuu1994

Copy link
Copy Markdown
Member

Think the AGENTS.md change makes sense. The CONTRIBUTING.md seems unnecessarily detailed, just mentioning to look for duplicates should be enough, if that's even useful at all. Somebody who won't check for duplicates won't check CONTRIBUTING.md.

@iliaal iliaal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval on removal of the "Thus, submitting duplicate pull requests is meaningless and a waste of everyone's time."

@iliaal

iliaal commented Oct 23, 2026

Copy link
Copy Markdown
Member

Think the AGENTS.md change makes sense. The CONTRIBUTING.md seems unnecessarily detailed, just mentioning to look for duplicates should be enough, if that's even useful at all. Somebody who won't check for duplicates won't check CONTRIBUTING.md.

Most agents check CONTRIBUTING.md (even when people don't) so from that perspective it is a good change imho.

@LamentXU123

LamentXU123 commented Oct 24, 2026 •

Copy link
Copy Markdown
Member Author

Yes. Its questionable which file agents will read and weights most because its effectively black box. We can always change it in the future if we might want but now lets merge it we've been flooded by AI generated duplicate PRs that might be written before.

@LamentXU123
LamentXU123 merged commit 4822a5d into php:master Oct 24, 2026
2 checks passed
Comment thread CONTRIBUTING.md
Comment on lines +43 to +44
If an open pull request already addresses the problem, help test or review it
to make it better instead of opening an equivalent pull request.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer duplicate PRs over discouraging contributions, especially when those PRs are higher quality and don’t require any additional investigation or iteration. At this point, it matters less who opens the PR first if AI-assisted workflows can produce a new PR within 15 minutes of an issue being filed.

What would be even better is encouraging issue authors to open PRs themselves. Some issues already include a patch or a fairly complete fix, so why not recommend opening a PR straight away?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants