Skip to content

Add FPM regression test for fatal backtrace reset - #24638

Merged
bukka merged 1 commit into
php:PHP-8.5from
aasul:tests/fpm-fatal-backtrace-reset-85
Oct 27, 2026
Merged

bukka merged 1 commit into
php:PHP-8.5from
aasul:tests/fpm-fatal-backtrace-reset-85

Conversation

@aasul

@aasul aasul commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

added an FPM regression test for the fatal backtrace cleanup from CVE-2026-109619

the test triggers a fatal error then sends another request to the same FPM worker with an invalid timezone setting. it checks that the previous backtrace doesnt carry over into the next request's warning and that the worker still works normally

tested on PHP 8.5.13-dev NTS debug and it passed. also tested against the pre-fix commit dd830558ffb with ASan and fast shutdown which failed twice with the expected memory error. the same test passed on the patched 31c0ea7d with no sanitizer errors

only added a PHPT test, no changes to the C code

related to GHSA-6wmf-4rv5-p3rp

@aasul
aasul requested a review from bukka as a code owner October 24, 2026 09:58
Copilot AI balanced review requested due to automatic review settings October 24, 2026 09:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments were identified, and all approval-readiness assessments support approval.

No open issues 🎉

Review effort: Lite

@aasul
aasul requested a balanced review from Copilot October 24, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@bukka

bukka commented Oct 27, 2026

Copy link
Copy Markdown
Member

I think it's not exactly regression as it wouldn't fail in CI before but the test is good as a smoke test so merging with a bit different commit message.

@bukka
bukka merged commit c9433e1 into php:PHP-8.5 Oct 27, 2026
17 of 18 checks passed
bukka added a commit that referenced this pull request Oct 27, 2026
* PHP-8.5:
  Add FPM test for INI diagnostics after fatal error with backtrace (#24638)
bukka added a commit that referenced this pull request Oct 27, 2026
* PHP-8.6:
  Add FPM test for INI diagnostics after fatal error with backtrace (#24638)
@aasul
aasul deleted the tests/fpm-fatal-backtrace-reset-85 branch October 27, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants