Skip to content

Fix GH-24697: cli: passing PHP_HTTP_PARSER_STRICT build option doesn't work #24704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndossche wants to merge 2 commits into from
Closed

Fix GH-24697: cli: passing PHP_HTTP_PARSER_STRICT build option doesn't work #24704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f33791
Fix GH-24697: cli: passing PHP_HTTP_PARSER_STRICT build option doesn'…
ndossche Oct 25, 2026
cc2d92d
Fix
ndossche Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sapi/cli/php_http_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ enum flags
#define start_state (parser->type == PHP_HTTP_REQUEST ? s_start_req : s_start_res)


#ifdef HTTP_PARSER_STRICT
#if HTTP_PARSER_STRICT
# define STRICT_CHECK(cond) if (cond) goto error
# define NEW_MESSAGE() (http_should_keep_alive(parser) ? start_state : s_dead)
#else
Expand Down
6 changes: 2 additions & 4 deletions sapi/cli/php_http_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,10 @@ extern "C" {

#include <stdint.h>

/* Compile with -DPHP_HTTP_PARSER_STRICT=0 to make less checks, but run
* faster
/* Compile with -DPHP_HTTP_PARSER_STRICT=1 to enable more checks, but run
* slower
*/
#ifndef PHP_HTTP_PARSER_STRICT
# define PHP_HTTP_PARSER_STRICT 1
#else
# define PHP_HTTP_PARSER_STRICT 0
#endif

Expand Down
Loading