Repository navigation
Fix tempnam() not being disabled in the fuzzer SAPI - #24719
Merged
Merged
Conversation
The disable_functions list contains "tempname", which does not exist, so tempnam() stays available and fuzz inputs can create files in /tmp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HARDCODED_INIinsapi/fuzzer/fuzzer-sapi.cdisables functions with file system side effects, but liststempnameinstead oftempnam.zend_disable_functions()silently ignores unknown names, sotempnam()is still callable. Runningphp-fuzz-executeon<?php tempnam("/tmp", "fuzzaudit_");creates a file in/tmp; with this patch it does not.Other write paths remain and are not addressed here, as they cannot be blocked through
disable_functionswithout losing coverage:error_log($msg, 3, $file)andnew SplFileObject($file, "w")both write files below theopen_basedir(/tmp).