Skip to content

Fix SQL test on Windows - #24755

Merged
shivammathur merged 1 commit into
php:PHP-8.2from
shivammathur:fix/php82-mysqli-poll-kill-test
Oct 26, 2026
Merged

shivammathur merged 1 commit into
php:PHP-8.2from
shivammathur:fix/php82-mysqli-poll-kill-test

Conversation

@shivammathur

@shivammathur shivammathur commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

This PR backport the mysqli_poll_kill.phpt test change to PHP-8.2 from 7801f40.

The Windows runner images have upgraded MySQL from 8.0 to 8.4, and thus removed COM_PROCESS_KILL, causing this test's mysqli_kill() calls to hang and stall Windows CI.
actions/runner-images#14993.

@kamil-tekiela

Copy link
Copy Markdown
Member

What is the point? We don't make any more development on PHP-8.2 branch so there won't be any new PRs.

@shivammathur

Copy link
Copy Markdown
Member Author

@kamil-tekiela We still run CI for PHP 8.2 and 8.3 as the branches gets security updates.

@kamil-tekiela kamil-tekiela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is ok, but I think it's a pointless change. Besides, I don't know how you merge this as PHP-8.2 is now a protected branch.

@shivammathur
shivammathur merged commit 0cb9da1 into php:PHP-8.2 Oct 26, 2026
18 checks passed
shivammathur added a commit to shivammathur/php-src that referenced this pull request Oct 26, 2026
* PHP-8.6:
  Fix SQL test on Windows (php#24755)
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-php__php-src that referenced this pull request Oct 26, 2026
* PHP-8.2:
  Fix SQL test on Windows (php#24755)
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-php__php-src that referenced this pull request Oct 26, 2026
* PHP-8.3:
  Fix SQL test on Windows (php#24755)
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-php__php-src that referenced this pull request Oct 26, 2026
* PHP-8.4:
  Fix SQL test on Windows (php#24755)
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-php__php-src that referenced this pull request Oct 26, 2026
* PHP-8.5:
  Fix SQL test on Windows (php#24755)
arnaud-lb added a commit to prateekbhujel/php-src that referenced this pull request Oct 27, 2026
* PHP-8.4: (26 commits)
  Fix phpGH-24695: FPM tester sends signal to process group when PID is missing (php#24698)
  Fix phpGH-24605: Guard var_export() against native stack overflow (php#24671)
  Fix use-after-free of CURLOPT_STDERR stream on cloned curl handle
  IR: Backport code buffer rollback fix
  Fix SQL test on Windows (php#24755)
  Fix phpGH-24697: cli: passing PHP_HTTP_PARSER_STRICT build option doesn't work
  Fix phpGH-24438: Preserve indirect types in JIT side traces
  Fix phpGH-17733: System entropy does not take into account function order, resulting in wrong functions possibly called in different configurations
  Fix unmapping of an unrelated range when the aligned chunk mmap fails (php#24542)
  Backport: Adapt intl timezone test expectations for ICU 79.1 (php#24724)
  Tracing JIT: keep the SEND_VAL type guard after assigning to a reference
  Backport: Adapt intl timezone test expectations for ICU 79.1 (php#24684)
  ext/zip: Reject broken libzip versions on Windows (php#24371)
  ext/zip: Exclude broken libzip 1.12 (php#24358)
  Fix phpGH-24264: Unwind/GracefulExit discarded in spl_iterators.c
  phpdbg: Backport watchpoint fixes to PHP-8.4
  Fix JIT reading packed-turned-hash array as packed after string key write
  ext/standard: Skip proc_open descriptor 0 tests without /proc/self/fd symlinks
  JIT: Fix operand type check in zend_redo_pass_two_ex() (php#24658)
  Fix error paths in dom_xml_serializing_a_document_node()
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants