Skip to content

Fix GH-24769: mb_ereg_replace() over-read on truncated trailing character #24772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+22 −2
Open

Fix GH-24769: mb_ereg_replace() over-read on truncated trailing character #24772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ext/mbstring/php_mbregex.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,9 @@ static inline void mb_regex_substitute(
clen = (int) php_mb_mbchar_bytes(p, enc);
if (clen != 1 || p == eos || p[0] != '\\') {
/* skip anything that's not an ascii backslash */
smart_str_appendl(pbuf, p, clen);
p += clen;
sp = p;
p = MIN(p + clen, eos);
smart_str_appendl(pbuf, sp, p - sp);
continue;
}
sp = p; /* save position */
Expand Down
19 changes: 19 additions & 0 deletions ext/mbstring/tests/gh24769.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
GH-24769 (mb_ereg_replace() reads past the replacement on a truncated trailing multibyte character)
--EXTENSIONS--
mbstring
--SKIPIF--
<?php
if (!function_exists('mb_ereg')) die('skip mbregex support not available');
?>
--FILE--
<?php
mb_regex_encoding('UTF-8');
var_dump(bin2hex(mb_ereg_replace('a', "x\xF0", 'a')));
var_dump(bin2hex(mb_ereg_replace('a', "x\xE2\x82", 'a')));
var_dump(bin2hex(mb_ereg_replace('a', "\xF0\x9F", 'bab')));
?>
--EXPECT--
string(4) "78f0"
string(6) "78e282"
string(8) "62f09f62"
Loading