Repository navigation
Conversation
The tracing guard checked IS_LONG instead of IS_STRING after ZVAL_DEREF, passing a non-string to zend_hash_find(). The function JIT path checked IS_STRING instead of IS_REFERENCE, so the deref fast path was dead.
jorgsowa
force-pushed
the
fix-jit-switch-string-ref
branch
from
October 27, 2026 17:51
43b8a6b to
a04a71e
Compare
iliaal
approved these changes
Oct 27, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
Good fix, plz resolve NEWS conflict so ci/cd can run
ndossche
approved these changes
Oct 27, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Interesting, so one crash fix and one fix so the fast path can be taken now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracing guard checked IS_LONG instead of IS_STRING after ZVAL_DEREF, passing a non-string to zend_hash_find(). The function JIT path checked IS_STRING instead of IS_REFERENCE, so the deref fast path was dead.
The test
switch_003.phptdoesn't fail before patch, because it was effectively dead code before. It's added for the proper test coverage.