Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_parse_body()has no reentrancy guard. If a user error handler that fires during multipart parsing calls it again, the nested parse re-inits and destroys the process-globalPG(rfc1867_protected_variables). The outer parse then uses and frees that same table a second time, so the worker crashes on a badzend_string_release().The function already keeps its state in
SG(request_parse_body_context), so I added anin_progressflag there. A reentrant call now throwsRequestParseBodyExceptioninstead of parsing again, and the flag is cleared on exit and at the per-request reset points.Fixes #24802