Skip to content

Fix typo in error message and improve database file existence check - #71

Open
sy-records wants to merge 1 commit into
masterfrom
fix/revcheck
Open

Fix typo in error message and improve database file existence check#71
sy-records wants to merge 1 commit into
masterfrom
fix/revcheck

Conversation

@sy-records

Copy link
Copy Markdown
Member

No description provided.

Comment thread www/revcheck.php Outdated

if ($lang !== 'en' && is_null($lang_intro)) {
site_header();
header('HTTP/1.1 404 Not Found');

@jordikroon jordikroon Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http_response_code(404) is probably nicer as it respects the server protocol.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jordikroon jordikroon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Shouldn't we set a status code 500 for the other guards as well?

Just a small nit, but lgtm

@sy-records

Copy link
Copy Markdown
Member Author

Add support for http_response_code in php/web-shared#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants