Skip to content

Table caption fix/update - #1994

Open
pwright64 wants to merge 1 commit into
php:masterfrom
pwright64:master
Open

Table caption fix/update#1994
pwright64 wants to merge 1 commit into
php:masterfrom
pwright64:master

Conversation

@pwright64

Copy link
Copy Markdown
Contributor

Change to table caption (table titles) behavior in mobile to fix table captions squishing and splitting to 3 lines. Also, increased .doctable caption line-height to 2rem for better readability.

Change to table caption (table titles) behavior in mobile to fix table captions squishing and splitting to 3 lines. Increased .doctable caption line-height to 2rem for better readability.
@pwright64

Copy link
Copy Markdown
Contributor Author

I'm not sure why the static analysis failed, but stylesheet changes did fine on my local php.net. If examples are needed for the changes: https://www.php.net/manual/en/mysqli.summary.php & https://www.php.net/manual/en/about.prototypes.php

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview for commit 0925948 is available at https://web-php-pr-1994.preview.thephp.foundation

@derickr

derickr commented Sep 1, 2026

Copy link
Copy Markdown
Member

Could you add a screenshot with before and after? The preview doesn't have all the documentation pages.

I would also prefer it if you split up the white-space-only changes from actual code-changes (same PR is fine, but in two separate commits, please).

@pwright64

pwright64 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Existing CSS on left, my changes on right

Image 1 showing main fix of unnecessary line breaks:
webphpPR1994

Image 2 showing line height on standalone table:
webphpPR1994lineheight

Image 3 showing line height on stacked tables (this page has been removed from documentation in recent PR but is the page I initially worked on, I don't know if there are other examples where similar page structure is used):
webphpPR1994lineheight2

Understood on the white space changes and code changes on separate commits. I will work on updated commits in the next 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants